Description

Fixes ISXB-658.

The InputStateWindow currently caches a bunch of state. When a device is disconnected, then reconnected, this state is reused. It is possible - likely based on the specifics of the device - that this will cause the window to memcpy from or into memory no longer owned by the device or the window leading to an editor crash.

To resolve this, I've used the same strategy used for the Input debugger window; when the device is disconnected - the window is force-closed.

Testing status & QA

I tested this locally using a Stadia controller, but it would be great to get some wider testing of devices on this before merging. Although I certainly don't see this as high risk.

Overall Product Risks

• Complexity: 0
• Halo Effect: 0

Comments to reviewers

The changes in DrawHexDump were to resolve some spammy null reference exception errors caused by the window. I believe it to be now unlikely that we'd run into a case where null reference exceptions are thrown during the drawing of the window, but there is no harm in doing these checks.

Checklist

Before review:

• Changelog entry added.
  • Explains the change in Changed, Fixed, Added sections.
  • For API change contains an example snippet and/or migration example.
  • JIRA ticket linked, example (case %%). If it is a private issue, just add the case ID without a link.
  • Jira port for the next release set as "Resolved".
• Tests added/changed, if applicable.
  • Functional tests Area_CanDoX, Area_CanDoX_EvenIfYIsTheCase, Area_WhenIDoX_AndYHappens_ThisIsTheResult.
  • Performance tests.
  • Integration tests.
• Docs for new/changed API's.
  • Xmldoc cross references are set correctly.
  • Added explanation how the API works.
  • Usage code examples added.
  • The manual is updated, if needed.

During merge:

• Commit message for squash-merge is prefixed with one of the list:
  • NEW: ___.
  • FIX: ___.
  • DOCS: ___.
  • CHANGE: ___.
  • RELEASE: 1.1.0-preview.3.

After merge:

• Create forward/backward port if needed. If you are blocked from creating a forward port now please add a task to ISX-1444.